Remove deprecated rules, but test for future ones #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickcharlton
force-pushed
the
nc-test-against-sample
branch
from
1d43946
to
c5bb451
Compare
nickcharlton
force-pushed
the
nc-fix-deprecated-rules
branch
3 times, most recently
from
a62f70e
to
4e4b000
Compare
nickcharlton
force-pushed
the
nc-test-against-sample
branch
from
0ac8630
to
53cc520
Compare
Upgrading `stylelint` to v15 deprecated a bunch of rules, which are intended to be handled by Prettier instead. This removes the style rules deprecated in that upgrade, alongside others which have changed. To try and catch when future rules are deprecated in upgrades, we add a test to see if the rule is listed as deprecated. Unfortunately, not all plugins follow the same method signature, so we need to check if `stylelint` knows about the rules before asserting on them. https://github.com/stylelint/stylelint/blob/main/docs/migration-guide/to-15.md https://github.com/stylelint/stylelint-config-standard/blob/main/__tests__/index.test.mjs
nickcharlton
force-pushed
the
nc-fix-deprecated-rules
branch
from
4e4b000
to
5e48f43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading
stylelintto v15 deprecated a bunch of rules, which are intended to be handled by Prettier instead.This removes the style rules deprecated in that upgrade, alongside others which have changed.
To try and catch when future rules are deprecated in upgrades, we add a test to see if the rule is listed as deprecated. Unfortunately, not all plugins follow the same method signature, so we need to check if
stylelintknows about the rules before asserting on them.https://github.com/stylelint/stylelint/blob/main/docs/migration-guide/to-15.md
https://github.com/stylelint/stylelint-config-standard/blob/main/__tests__/index.test.mjs