Update dynamic README workflow to open a Pull Request #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 2, 2024 17:05
Some repositories have a protected branch rule. That means our workflow won't work because commiting directly to main is not allowed. To prevent that, the workflow will now open a PR for the changes.
We only want to run this workflow if the README has changed, not on every change.
As @nickcharlton pointed out, > the leading / implies to me the start of a filesystem, which it presumably isn't. I tested removing it and it worked, so it was probably needed when I was testing things but it's not needed anymore.
This was referenced Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some repositories have a protected branch rule. That means our workflow won't work because commiting directly to main
is not allowed. To prevent that, the workflow will now open a PR for the changes. Rather than chancing the repo rules, updating the workflow is easier. Probably safer, too.
Other updates include only running the workflow when the README is updated. And removing the leading
/that indicates it's a file (but it isn't). @nickcharlton pointed it out here. It must have been needed when I was testing things but it works fine without it on this test repo.