Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly use OpenCV 2 #336

Closed
nitsch opened this issue Dec 4, 2017 · 2 comments
Closed

Explicitly use OpenCV 2 #336

nitsch opened this issue Dec 4, 2017 · 2 comments

Comments

@nitsch
Copy link
Collaborator

nitsch commented Dec 4, 2017

We should use a version from OpenCV's 2.x branch. The C API was deprecated in OpenCV 3.x, and stuff breaks (see #335, #251). Plus, there really is no need to use OpenCV 3. We use non of its features. The 2.x branch is still maintained by OpenCV folks.

If there are mentions of OpenCV 3 in the documentation, they should be replaced. If some of the build scripts either use OpenCV 3 or do not specifically use 2.x, they should be fixed, too.
@thp
Copy link
Owner

thp commented Dec 9, 2017

Yes, is there any good branch in upstream OpenCV that we could reference?

@nitsch
Copy link
Collaborator Author

nitsch commented Dec 9, 2017 via email

@thp thp closed this as completed in b456090 Dec 30, 2017
thp added a commit that referenced this issue Dec 30, 2017
@thp
Merge pull request #339 from thp/use-opencv-2
23a5705 
Use OpenCV 2.4 (Fixes #336)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thp @nitsch