Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wish] Update File Version would update ;@Ahk2Exe-SetVersion #565

Closed
RaptorX opened this issue Aug 9, 2024 · 6 comments
Closed

[Wish] Update File Version would update ;@Ahk2Exe-SetVersion #565

RaptorX opened this issue Aug 9, 2024 · 6 comments

Comments

@RaptorX
Copy link
Contributor

RaptorX commented Aug 9, 2024

It would be nice if the Update File Version function updates the @version property of the first JSDoc comment in the script but also any ;@Ahk2Exe-SetVersion found as well, as they are usually the same thing.

thqby added a commit that referenced this issue Aug 31, 2024
@thqby thqby closed this as completed Aug 31, 2024
@RaptorX
Copy link
Contributor Author

RaptorX commented Sep 1, 2024

I dont think it is working at the moment, is there any special syntax for this?

@mark-wiemer
Copy link
Contributor

I don't think the change has been released yet :)

@thqby
Copy link
Owner

thqby commented Sep 2, 2024

Failed when line comments exist on the previous line of the instruction, correct?

@RaptorX
Copy link
Contributor Author

RaptorX commented Sep 2, 2024

I don't think the change has been released yet :)

It was marked as completed a few hours ago.

Failed when line comments exist on the previous line of the instruction, correct?

Yes, I have other ahk2exe comments right above it

@mark-wiemer
Copy link
Contributor

Yes, the issue is closed as completed, but generally that does not mean the fix has been released. This is true for thqby's extension, AHK++, and most codebases I've worked with. Usually issues are closed once the code is updated, but there is a delay between updating the code and releasing an updated package. You'll see thqby's extension hasn't been updated since yesterday, so you won't see the changes quite yet. Expect this to be fully resolved when 2.5.2 comes out :)

https://marketplace.visualstudio.com/items?itemName=thqby.vscode-autohotkey2-lsp

image

@RaptorX
Copy link
Contributor Author

RaptorX commented Sep 2, 2024

Yes, the issue is closed as completed, but generally that does not mean the fix has been released. This is true for thqby's extension, AHK++, and most codebases I've worked with. Usually issues are closed once the code is updated, but there is a delay between updating the code and releasing an updated package. You'll see thqby's extension hasn't been updated since yesterday, so you won't see the changes quite yet. Expect this to be fully resolved when 2.5.2 comes out :)

Oh I see. I didn't know that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants