Feature/react webapp

[marcofranssen]

No description provided.

[codecov-io]

Codecov Report

Merging #210 into react-web will increase coverage by 0.15%.
The diff coverage is 51.45%.

@@              Coverage Diff              @@
##           react-web     #210      +/-   ##
=============================================
+ Coverage       37.3%   37.45%   +0.15%     
=============================================
  Files            115      136      +21     
  Lines          22106    22347     +241     
  Branches           0       37      +37     
=============================================
+ Hits            8246     8370     +124     
- Misses         13129    13233     +104     
- Partials         731      744      +13

Impacted Files	Coverage Δ
web/src/components/Navigation/Navigation.js	0% <0%> (ø)
web/src/electron-starter.js	0% <0%> (ø)
web/src/registerServiceWorker.js	0% <0%> (ø)
web/src/index.js	0% <0%> (ø)
web/src/pages/styles.js	100% <100%> (ø)
web/src/pages/Home/Home.js	100% <100%> (ø)
web/src/components/ListItemLink/ListItemLink.js	100% <100%> (ø)
web/src/components/AppBar/AppBar.js	100% <100%> (ø)
web/src/pages/About/About.js	100% <100%> (ø)
web/src/pages/NotFound/NotFound.js	100% <100%> (ø)
... and 32 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9253424...492bafd. Read the comment docs.

[gloriousCode]

Hello! Thank you for this large PR!
I've left comments on the main things that I've noticed that need changes.
Even after that, there are some things I'll need to clarify with Thrasher regarding the front end before we can look to merge it
👍

[gloriousCode]

Thanks for making those changes!

A few more things have com up:
npm run electron is having issues with the pathing:

npm run electron-dev does not render:

[marcofranssen]

See the Readme file in the web folder. For electron dev you should do npm start before.

For the other on npm run build as documented in Readme.

[gloriousCode]

Alright with the npm start for dev. The first screen was with npm run build -> npm run electron still has the pathing issues

[marcofranssen]

Let me check that tonight after work. Will have some time then.

[marcofranssen]

I have asked for help on that pathing issue in following places.

facebook/create-react-app#1718
https://medium.freecodecamp.org/building-an-electron-application-with-create-react-app-97945861647c

On the other hand we can continue development also on the browser, so do we need to wait for the electron fix?

Copy of the explanation I gave on other github issue

"homepage": "./" does not resolve everything in electron.

static resources like images do not work.

import logo from '../../assets/images/logo.svg';

....
....

<img src={logo} className={classes.logo} alt="logo" />

Neither fetching data using relative paths is working. e.g.

let response = fetch('data/donation-addresses.json');

It will try to access them using an absolute path starting with /.

So instead of trying to access at:
data/donation-addresses.json goes to /data/donation-addresses.json

Same for the image:
assets/images/logo.svg goes to /assets/images/logo.svg.

Any ideas on how to resolve that?