Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart laurel on SIGHUP #158

Merged
merged 1 commit into from
Jul 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ caps = "0.5"
libc = "0.2"
exacl = ">= 0.6"
regex = "1"
signal-hook = "0.3"
tinyvec = { version = "1", features = ["alloc"] }

log = "0.4"
Expand Down
7 changes: 6 additions & 1 deletion src/coalesce.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1054,6 +1054,11 @@ impl<'a> Coalesce<'a> {
Ok(())
}

/// Flush all in-flight event data, including partial events
pub fn flush(&mut self) {
self.expire_inflight(u64::MAX);
}

pub fn dump_state(&self, mut w: &mut dyn Write) -> Result<(), Box<dyn Error>> {
serde_json::to_writer(
&mut w,
Expand Down Expand Up @@ -1092,7 +1097,7 @@ impl<'a> Coalesce<'a> {

impl Drop for Coalesce<'_> {
fn drop(&mut self) {
self.expire_inflight(u64::MAX)
self.flush();
}
}

Expand Down
51 changes: 47 additions & 4 deletions src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,13 @@ use std::os::unix::fs::PermissionsExt;
use std::os::unix::io::FromRawFd;
use std::os::unix::net::UnixStream;
use std::path::Path;
use std::sync::{
atomic::{AtomicBool, Ordering},
Arc,
};
use std::time::{Duration, SystemTime};

use nix::unistd::{chown, setresgid, setresuid, Uid, User};
use nix::unistd::{chown, execve, setresgid, setresuid, Uid, User};

use caps::securebits::set_keepcaps;
use caps::{CapSet, Capability};
Expand Down Expand Up @@ -64,11 +68,11 @@ fn drop_privileges(runas_user: &User) -> Result<(), Box<dyn Error>> {
capabilities.insert(Capability::CAP_SYS_PTRACE);
capabilities.insert(Capability::CAP_DAC_READ_SEARCH);
caps::set(None, CapSet::Permitted, &capabilities)
.map_err(|e| format!("set effective capabilities: {}", e))?;
.map_err(|e| format!("set permitted capabilities: {}", e))?;
caps::set(None, CapSet::Effective, &capabilities)
.map_err(|e| format!("set effective capabilities: {}", e))?;
caps::set(None, CapSet::Inheritable, &HashSet::new())
.map_err(|e| format!("set inherited capabilities: {}", e))?;
caps::set(None, CapSet::Inheritable, &capabilities)
.map_err(|e| format!("set inheritable capabilities: {}", e))?;

set_keepcaps(false)?;
Ok(())
Expand Down Expand Up @@ -270,6 +274,9 @@ fn run_app() -> Result<(), Box<dyn Error>> {
// Logged to syslog by caller
return Err(e);
}
if let Err(e) = caps::clear(None, CapSet::Ambient) {
log::warn!("could not set ambient capabilities: {}", e);
}

// Initial setup is done at this point.

Expand All @@ -294,7 +301,42 @@ fn run_app() -> Result<(), Box<dyn Error>> {
let dump_state_period = config.debug.dump_state_period.map(Duration::from_secs);
let mut dump_state_last_t = SystemTime::now();

let hup = Arc::new(AtomicBool::new(false));
signal_hook::flag::register(signal_hook::consts::SIGHUP, Arc::clone(&hup))?;

loop {
if hup.load(Ordering::Relaxed) {
let buf = input.buffer();
let lines = buf.split_inclusive(|c| *c == b'\n');
log::info!("Got SIGHUP.");
for line in lines {
if let Err(e) = coalesce.process_line(line.to_vec()) {
if let Some(ref mut l) = error_logger {
l.write_all(line)
.and_then(|_| l.flush())
.map_err(|e| format!("write log: {}", e))?;
}
let line = String::from_utf8_lossy(line).replace('\n', "");
log::error!("Error {} processing msg: {}", e, &line);
}
}
coalesce.flush();
log::info!("Restarting...");
use std::ffi::CString;
let argv: Vec<CString> = env::args().map(|a| CString::new(a).unwrap()).collect();
let env: Vec<CString> = env::vars()
.map(|(k, v)| CString::new(format!("{}={}", k, v)).unwrap())
.collect();

let mut capabilities = HashSet::new();
capabilities.insert(Capability::CAP_SYS_PTRACE);
capabilities.insert(Capability::CAP_DAC_READ_SEARCH);
if let Err(e) = caps::set(None, CapSet::Ambient, &capabilities) {
log::warn!("could not set ambient capabilities: {}", e);
}
execve(&argv[0], &argv, &env)?;
}

line.clear();
if input
.read_until(b'\n', &mut line)
Expand All @@ -303,6 +345,7 @@ fn run_app() -> Result<(), Box<dyn Error>> {
{
break;
}

stats.lines += 1;
match coalesce.process_line(line.clone()) {
Ok(()) => (),
Expand Down
Loading