WebGPURenderer: Better skinning performance (#836)

three-types · Feb 23, 2024 · 0086896 · 0086896
1 parent b1949e9
commit 0086896
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 8 deletions.
diff --git a/types/three/examples/jsm/nodes/Nodes.d.ts b/types/three/examples/jsm/nodes/Nodes.d.ts
@@ -270,7 +270,7 @@ export {
     positionWorld,
     positionWorldDirection,
 } from "./accessors/PositionNode.js";
-export { default as ReferenceNode, reference } from "./accessors/ReferenceNode.js";
+export { default as ReferenceNode, reference, referenceBuffer } from "./accessors/ReferenceNode.js";
 export { default as ReflectVectorNode, reflectVector } from "./accessors/ReflectVectorNode.js";
 export { default as SkinningNode, skinning } from "./accessors/SkinningNode.js";
 export { default as StorageBufferNode, storage, storageObject } from "./accessors/StorageBufferNode.js";

diff --git a/types/three/examples/jsm/nodes/accessors/ReferenceNode.d.ts b/types/three/examples/jsm/nodes/accessors/ReferenceNode.d.ts
@@ -4,24 +4,25 @@ import { NodeOrType, NodeRepresentation, ShaderNodeObject } from "../shadernode/
 
 export default class ReferenceNode<T> extends Node {
     property: string;
-    indexNode: Node | null;
 
     uniformType: NodeTypeOption;
 
     object: T;
-    reference: T | null;
+    count: number | null;
 
+    properties: string[];
+    reference: T | null;
     node: Node | null;
 
-    constructor(property: string, uniformType: NodeTypeOption, object?: T | null, indexNode?: Node | null);
+    constructor(property: string, uniformType: NodeTypeOption, object?: T | null, count?: number | null);
 
     setNodeType(uniformType: NodeTypeOption): void;
 }
 
 export const reference: <T>(name: string, nodeOrType: NodeOrType, object: T) => ShaderNodeObject<ReferenceNode<T>>;
-export const referenceIndex: <T>(
+export const referenceBuffer: <T>(
     name: string,
-    index: NodeRepresentation,
     nodeOrType: NodeOrType,
+    count: NodeRepresentation,
     object: T,
 ) => ShaderNodeObject<ReferenceNode<T>>;
diff --git a/types/three/examples/jsm/nodes/accessors/SkinningNode.d.ts b/types/three/examples/jsm/nodes/accessors/SkinningNode.d.ts
@@ -3,14 +3,18 @@ import Node from "../core/Node.js";
 import { ShaderNodeObject } from "../shadernode/ShaderNode.js";
 
 export default class SkinningNode extends Node {
+    skinnedMesh: SkinnedMesh;
+    useReference: boolean;
+
     skinIndexNode: Node;
     skinWeightNode: Node;
 
     bindMatrixNode: Node;
     bindMatrixInverseNode: Node;
     boneMatricesNode: Node;
 
-    constructor(skinnedMesh: SkinnedMesh);
+    constructor(skinnedMesh: SkinnedMesh, useReference?: boolean);
 }
 
-export function skinning(skinnedMesh: SkinnedMesh): ShaderNodeObject<SkinningNode>;
+export const skinning: (skinnedMesh: SkinnedMesh) => ShaderNodeObject<SkinningNode>;
+export const skinningReference: (skinnedMesh: SkinnedMesh) => ShaderNodeObject<SkinningNode>;