Skip to content

Commit

Permalink
Add sessionInit parameter to VRButton (#825)
Browse files Browse the repository at this point in the history
* Add sessionInit parameter to VRButton

* Update three.js

* Add examples

* Update patch

* Delete examples
  • Loading branch information
Methuselah96 authored Feb 20, 2024
1 parent 1ada12e commit 2106c34
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion examples-testing/changes.patch
Original file line number Diff line number Diff line change
Expand Up @@ -14326,7 +14326,7 @@ index 1a9c4de..53cb684 100644
init();
animate();
diff --git a/examples-testing/examples/webxr_vr_handinput.ts b/examples-testing/examples/webxr_vr_handinput.ts
index a896103..797674f 100644
index d3c2cdd..06aad83 100644
--- a/examples-testing/examples/webxr_vr_handinput.ts
+++ b/examples-testing/examples/webxr_vr_handinput.ts
@@ -4,13 +4,13 @@ import { VRButton } from 'three/addons/webxr/VRButton.js';
Expand Down
2 changes: 1 addition & 1 deletion three.js
Submodule three.js updated 29 files
+11 −1 examples/jsm/exporters/GLTFExporter.js
+1 −0 examples/jsm/misc/ProgressiveLightMap.js
+3 −2 examples/jsm/nodes/Nodes.js
+6 −0 examples/jsm/nodes/accessors/AccessorsUtils.js
+5 −5 examples/jsm/nodes/accessors/MorphNode.js
+22 −22 examples/jsm/nodes/accessors/ReferenceNode.js
+2 −2 examples/jsm/nodes/accessors/TangentNode.js
+140 −0 examples/jsm/nodes/accessors/UniformsNode.js
+0 −26 examples/jsm/nodes/core/ArrayUniformNode.js
+3 −5 examples/jsm/nodes/display/NormalMapNode.js
+6 −4 examples/jsm/renderers/common/UniformsGroup.js
+2 −3 examples/jsm/renderers/webgl/WebGLBackend.js
+26 −27 examples/jsm/renderers/webgl/nodes/GLSLNodeBuilder.js
+11 −0 examples/jsm/renderers/webgl/utils/WebGLTextureUtils.js
+1 −0 examples/jsm/renderers/webgl/utils/WebGLUtils.js
+3 −36 examples/jsm/renderers/webgpu/nodes/WGSLNodeBuilder.js
+6 −0 examples/jsm/renderers/webgpu/utils/WebGPUAttributeUtils.js
+13 −5 examples/jsm/webxr/VRButton.js
+0 −1 examples/jsm/webxr/XRButton.js
+ examples/screenshots/webgpu_loader_gltf_compressed.jpg
+ examples/screenshots/webgpu_storage_buffer.jpg
+68 −14 examples/webgpu_storage_buffer.html
+5 −1 examples/webxr_vr_handinput.html
+5 −1 examples/webxr_vr_handinput_cubes.html
+5 −1 examples/webxr_vr_handinput_pointerclick.html
+5 −1 examples/webxr_vr_handinput_pointerdrag.html
+5 −1 examples/webxr_vr_handinput_pressbutton.html
+5 −1 examples/webxr_vr_handinput_profiles.html
+5 −1 src/renderers/webgl/WebGLState.js
4 changes: 2 additions & 2 deletions types/three/examples/jsm/webxr/VRButton.d.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { WebGLRenderer } from "three";

export namespace VRButton {
function createButton(renderer: WebGLRenderer): HTMLElement;
export class VRButton {
static createButton(renderer: WebGLRenderer, sessionInit?: XRSessionInit): HTMLElement;
}
1 change: 0 additions & 1 deletion types/three/examples/jsm/webxr/XRButton.d.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { WebGLRenderer } from "three";

// tslint:disable-next-line:no-unnecessary-class
export class XRButton {
static createButton(renderer: WebGLRenderer, sessionInit?: XRSessionInit): HTMLElement;
}

0 comments on commit 2106c34

Please sign in to comment.