Improve Matrix toArray typings (#1132)

* Improve Matrix toArray typings * Update
three-types · Jul 25, 2024 · 8b549ac · 8b549ac
1 parent 19da889
commit 8b549ac
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/types/three/src/math/Matrix3.d.ts b/types/three/src/math/Matrix3.d.ts
@@ -170,10 +170,15 @@ export class Matrix3 {
     /**
      * Writes the elements of this matrix to an array in
      * {@link https://en.wikipedia.org/wiki/Row-_and_column-major_order#Column-major_order column-major} format.
-     * @param array (optional) array to store the resulting vector in. If not given a new array will be created.
+     */
+    toArray(): Matrix3Tuple;
+    /**
+     * Writes the elements of this matrix to an array in
+     * {@link https://en.wikipedia.org/wiki/Row-_and_column-major_order#Column-major_order column-major} format.
+     * @param array array to store the resulting vector in. If not given a new array will be created.
      * @param offset (optional) offset in the array at which to put the result.
      */
-    toArray<TArray extends ArrayLike<number> = number[]>(array?: TArray, offset?: number): TArray;
+    toArray<TArray extends ArrayLike<number>>(array: TArray, offset?: number): TArray;
 
     clone(): this;
 }
diff --git a/types/three/src/math/Matrix4.d.ts b/types/three/src/math/Matrix4.d.ts
@@ -272,8 +272,13 @@ export class Matrix4 {
     /**
      * Writes the elements of this matrix to an array in
      * {@link https://en.wikipedia.org/wiki/Row-_and_column-major_order#Column-major_order column-major} format.
-     * @param array (optional) array to store the resulting vector in.
+     */
+    toArray(): Matrix4Tuple;
+    /**
+     * Writes the elements of this matrix to an array in
+     * {@link https://en.wikipedia.org/wiki/Row-_and_column-major_order#Column-major_order column-major} format.
+     * @param array array to store the resulting vector in.
      * @param offset (optional) offset in the array at which to put the result.
      */
-    toArray<TArray extends ArrayLike<number> = number[]>(array?: TArray, offset?: number): TArray;
+    toArray<TArray extends ArrayLike<number>>(array: TArray, offset?: number): TArray;
 }