Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LineMaterialParameters: extends ShaderMaterialParameters not MaterialParameters #1013

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

puxiao
Copy link
Contributor

@puxiao puxiao commented Jun 14, 2024

class LineMaterial extends ShaderMaterial { ... }

So, the constructor parameters should also extends ShaderMaterialParameters , not MaterialParameters .


export interface ShaderMaterialParameters extends MaterialParameters {
    ...
    linewidth?: number | undefined;
    wireframe?: boolean | undefined;
    ...
}

So, We can remove linewidth and wireframe from LineMaterialParameters.

@puxiao puxiao changed the title LineMaterialParameters: extends ShaderMaterialParameters not Material… LineMaterialParameters: extends ShaderMaterialParameters not MaterialParameters Jun 14, 2024
Copy link
Contributor

@Methuselah96 Methuselah96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Methuselah96 Methuselah96 merged commit bebce7d into three-types:master Jun 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants