-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Material type definitions: Add MaterialJSON format #1072
Merged
Commits on Jul 17, 2024
-
Update Material type definitions: Add MaterialJSON format
Introduces the MaterialJSON format in Three.js, which extends the Material interface. The new format includes serializable properties such as color, roughness, metallic, map, normalMap, and many more. This change enables better JSON parsing and handling of material configurations for Three.js applications. Confirmed: Types and interfaces have been updated in Object3D.d.ts and Material.d.ts. The Material class has also been updated to include toJSON methods that return MaterialJSON or MaterialJSONRoot objects based on the provided meta data. Reference(s): three-types#1071 three-types#1070 three-types#426
Configuration menu - View commit details
-
Copy full SHA for 94e871d - Browse repository at this point
Copy the full SHA 94e871dView commit details -
Fix: Error: 240:16 error Array type using 'T[]' is forbidden for non-…
…simple types. Use 'Array<T>' instead @typescript-eslint/array-type
Configuration menu - View commit details
-
Copy full SHA for bce8955 - Browse repository at this point
Copy the full SHA bce8955View commit details -
Configuration menu - View commit details
-
Copy full SHA for f04645b - Browse repository at this point
Copy the full SHA f04645bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d1a7bc9 - Browse repository at this point
Copy the full SHA d1a7bc9View commit details -
Error: 105:28 error Array type using 'Array<number>' is forbidden for simple types. Use 'number[]' instead @typescript-eslint/array-type Error: 136:19 error Array type using 'Array<number>' is forbidden for simple types. Use 'number[]' instead @typescript-eslint/array-type Error: 157:22 error Array type using 'Array<number>' is forbidden for simple types. Use 'number[]' instead @typescript-eslint/array-type Error: 242:14 error Array type using 'Array<SourceJSON>' is forbidden for simple types. Use 'SourceJSON[]' instead @typescript-eslint/array-type
Configuration menu - View commit details
-
Copy full SHA for 115faea - Browse repository at this point
Copy the full SHA 115faeaView commit details -
Error: 240:16 error Array type using 'T[]' is forbidden for non-simpl…
…e types. Use 'Array<T>' instead @typescript-eslint/array-type
Configuration menu - View commit details
-
Copy full SHA for 0491ae8 - Browse repository at this point
Copy the full SHA 0491ae8View commit details
Commits on Jul 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 20518ba - Browse repository at this point
Copy the full SHA 20518baView commit details -
Configuration menu - View commit details
-
Copy full SHA for e70ca24 - Browse repository at this point
Copy the full SHA e70ca24View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba4e09b - Browse repository at this point
Copy the full SHA ba4e09bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.