Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LightingModel: Refactor indirect lighting (2) #1133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

LightingModel: Refactor indirect lighting (2) #1133

wants to merge 1 commit into from

Conversation

0b5vr
Copy link
Contributor

@0b5vr 0b5vr commented Jul 26, 2024

.ambientOcclusion also integrated into .indirect

Sequel of 9724d59

See: mrdoob/three.js#28824

@0b5vr
LightingModel: Refactor indirect lighting (2)
ab67c70 
`.ambientOcclusion` also integrated into `.indirect`

Sequel of 9724d59

See: mrdoob/three.js#28824
@0b5vr 0b5vr requested a review from Methuselah96 July 26, 2024 09:21
@0b5vr 0b5vr self-assigned this Jul 26, 2024
@Methuselah96
Copy link
Contributor

Are you sure? I still see ambientOcclusion right here.

@Methuselah96
Copy link
Contributor

Methuselah96 commented Jul 26, 2024 •
edited
Loading

Oh, I guess it just didn't get removed from the LightingModel class, even though it doesn't get called from LightsNode anymore. Can you create a PR on three.js to do that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Methuselah96 Methuselah96 Awaiting requested review from Methuselah96

At least 1 approving review is required to merge this pull request.

Assignees

@0b5vr 0b5vr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0b5vr @Methuselah96