Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add WebXRManager exports back #1140

Merged
merged 2 commits into from
Aug 5, 2024
Merged

fix: add WebXRManager exports back #1140

merged 2 commits into from
Aug 5, 2024

Conversation

asyncore
Copy link
Contributor

@asyncore asyncore commented Aug 5, 2024

This PR adds the WebXRManager export back in Three.d.ts which was inadvertently removed in PR #1079 and fixes Issue #1139.

Copy link
Contributor

@Methuselah96 Methuselah96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I updated the PR to export the types only

@Methuselah96 Methuselah96 linked an issue Aug 5, 2024 that may be closed by this pull request
@Methuselah96 Methuselah96 merged commit ef41ce0 into three-types:master Aug 5, 2024
5 checks passed
@Methuselah96
Copy link
Contributor

I create a PR on DefinitelyTyped to get this change released since it's a regression in the r167 release and seems worth patching before r168.

@asyncore asyncore deleted the fix/1139-fix-webxrmanager-export branch August 5, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing WebXRManager exports in r167
2 participants