Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require type-checking to pass for src-testing #1228

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −39
Draft

Require type-checking to pass for src-testing #1228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d9689f
Require type-checking to pass for src-testing
Methuselah96 Sep 17, 2024
3f78ad9
Remove non-built declarations
Methuselah96 Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ jobs:
working-directory: src-testing
- run: pnpm run build-declarations
working-directory: src-testing
continue-on-error: true
- run: pnpm run format-dprint
working-directory: src-testing
- run: pnpm run check-declarations
Expand Down
36 changes: 2 additions & 34 deletions src-testing/create-src.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,46 +4,24 @@ import * as path from 'node:path';
import prettier from 'prettier';

const files = [
'materials/nodes/NodeMaterial',
'nodes/accessors/BufferAttributeNode',
'nodes/accessors/TextureNode',
'nodes/code/CodeNode',
'nodes/code/FunctionNode',
'nodes/core/constants',
'nodes/core/ContextNode',
'nodes/core/InputNode',
'nodes/core/Node',
'nodes/core/NodeAttribute',
'nodes/core/NodeBuilder',
'nodes/core/NodeCache',
'nodes/core/NodeCode',
'nodes/core/NodeFrame',
'nodes/core/NodeFunction',
'nodes/core/NodeParser',
'nodes/core/NodeUniform',
'nodes/core/NodeUtils',
'nodes/core/NodeVar',
'nodes/core/NodeVarying',
'nodes/core/StackNode',
'nodes/core/StructTypeNode',
'nodes/core/UniformGroupNode',
'nodes/core/UniformNode',
'nodes/fog/FogNode',
'nodes/gpgpu/ComputeNode',
'nodes/lighting/EnvironmentNode',
'nodes/lighting/LightingContextNode',
'nodes/lighting/LightsNode',
'nodes/tsl/TSLCore',
'nodes/Nodes',
'renderers/common/extras/PMREMGenerator',
'renderers/common/nodes/NodeBuilderState',
'renderers/common/nodes/NodeLibrary',
'renderers/common/nodes/Nodes',
'renderers/common/nodes/NodeUniform',
'renderers/common/nodes/NodeUniformsGroup',
'renderers/common/nodes/Nodes',
'renderers/common/Animation',
'renderers/common/Attributes',
'renderers/common/Backend',
'renderers/common/Background',
'renderers/common/BindGroup',
'renderers/common/Binding',
Expand All @@ -67,28 +45,18 @@ const files = [
'renderers/common/RenderBundles',
'renderers/common/RenderContext',
'renderers/common/RenderContexts',
'renderers/common/Renderer',
'renderers/common/RenderList',
'renderers/common/RenderLists',
'renderers/common/Renderer',
'renderers/common/RenderObject',
'renderers/common/RenderObjects',
'renderers/common/RenderPipeline',
'renderers/common/SampledTexture',
'renderers/common/Sampler',
'renderers/common/StorageBuffer',
'renderers/common/Textures',
'renderers/common/Uniform',
'renderers/common/UniformBuffer',
'renderers/common/UniformsGroup',
'renderers/webgl-fallback/nodes/GLSLNodeBuilder',
'renderers/webgl-fallback/WebGLBackend',
'renderers/webgpu/nodes/BasicNodeLibrary',
'renderers/webgpu/nodes/StandardNodeLibrary',
'renderers/webgpu/nodes/WGSLNodeBuilder',
'renderers/webgpu/nodes/WGSLNodeFunction',
'renderers/webgpu/nodes/WGSLNodeParser',
'renderers/webgpu/WebGPUBackend',
'renderers/webgpu/WebGPURenderer',
];

const javascriptInDir = '../three.js/src';
Expand Down
2 changes: 1 addition & 1 deletion src-testing/declarations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ const files = [
'nodes/core/StructTypeNode',
'nodes/core/UniformNode',
'renderers/common/nodes/NodeBuilderState',
'renderers/common/nodes/Nodes',
'renderers/common/nodes/NodeLibrary',
'renderers/common/nodes/Nodes',
'renderers/common/nodes/NodeUniform',
'renderers/common/nodes/NodeUniformsGroup',
'renderers/common/Animation',
Expand Down
2 changes: 1 addition & 1 deletion src-testing/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"main": "",
"scripts": {
"create-src": "node create-src.js",
"build-declarations": "tsc",
"build-declarations": "tsc --declaration true --emitDeclarationOnly true",
"check-declarations": "node declarations.js check",
"copy-declarations": "node declarations.js copy",
"type-check": "tsc --noEmit",
Expand Down
2 changes: 0 additions & 2 deletions src-testing/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
"target": "es2017",
"module": "NodeNext",
"types": [],
"declaration": true,
"emitDeclarationOnly": true,
"forceConsistentCasingInFileNames": true,
"strict": true
}
Expand Down
Loading