Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change (WebGLMultipleRenderTargets): Add Options to Constructor #187

Merged
merged 2 commits into from
Mar 1, 2022
Merged

change (WebGLMultipleRenderTargets): Add Options to Constructor #187

merged 2 commits into from
Mar 1, 2022

Conversation

0b5vr
Copy link
Contributor

@0b5vr 0b5vr commented Mar 1, 2022 •
edited
Loading

Why

To catch up with r138

What

See: mrdoob/three.js#22772

  • Add an options argument to the constructor of WebGLMultipleRenderTargets

Checklist

  • Checked the target branch (current goes master, next goes dev)
  • Added myself to contributors table
  • Ready to be merged

@0b5vr 0b5vr mentioned this pull request Mar 1, 2022
Closed
16 tasks
@0b5vr
Copy link
Contributor Author

0b5vr commented Mar 1, 2022

WebGLMultipleRenderTargets has been removed @ mrdoob/three.js#23455 .
This is no longer a necessary PR, closing.

@0b5vr 0b5vr closed this Mar 1, 2022
@0b5vr 0b5vr deleted the webglmultiplerendertargets branch March 1, 2022 07:09
@0b5vr 0b5vr restored the webglmultiplerendertargets branch March 1, 2022 07:11
@0b5vr
Copy link
Contributor Author

0b5vr commented Mar 1, 2022

no that was WebGLMultisampleRenderTarget uhhh, reopening

@0b5vr 0b5vr reopened this Mar 1, 2022
@joshuaellis joshuaellis merged commit 2a00f3c into three-types:dev Mar 1, 2022
@0b5vr 0b5vr deleted the webglmultiplerendertargets branch March 1, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaellis joshuaellis joshuaellis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0b5vr @joshuaellis