Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLTFLoaderPlugin: add constructor and required name getter #728

Merged

Conversation

hybridherbst
Copy link
Contributor

Copy link
Contributor

@Methuselah96 Methuselah96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

The parser is already getting passed via the callback in the register and unregister, so I don't think adding a constructor is correct.

export class GLTFLoader extends Loader<GLTF> {
    // ...
    register(callback: (parser: GLTFParser) => GLTFLoaderPlugin): GLTFLoader;
    unregister(callback: (parser: GLTFParser) => GLTFLoaderPlugin): GLTFLoader;
    // ...
}

hybridherbst

This comment was marked as duplicate.

@hybridherbst
Copy link
Contributor Author

Thanks! I think you're right about the constructor, and I changed to the readonly prop.

@Methuselah96 Methuselah96 merged commit 01a4e30 into three-types:master Jan 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants