fix: Mark third argument of materialReference as nullable
#732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0b5vr
force-pushed
the
material-reference-third
branch
from
201276f
to
85f953f
Compare
Methuselah96
reviewed
Jan 9, 2024
types/three/examples/jsm/nodes/accessors/MaterialReferenceNode.d.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The third argument of
materialReferenceshould be nullable.The definition on Three.js: https://github.com/mrdoob/three.js/blob/r160/examples/jsm/nodes/accessors/MaterialReferenceNode.js#L9
The actual use of
materialReferencewithout the third argument (and this is the only use ofmaterialReferencein the Three.js repository): https://github.com/mrdoob/three.js/blob/85b3ee713ae64ac1db20fd9dd29d2892d10fab3d/examples/jsm/nodes/accessors/MaterialNode.js#L25