Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLPrograms: Update fogExp2 parameter #736

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

vanruesc
Copy link
Contributor

This change is for three r161, see mrdoob/three.js#27430.

@0b5vr
Copy link
Contributor

0b5vr commented Dec 26, 2023

@vanruesc good one! the PR should be directed to dev instead of master though, since it's a change for the next release of Three.js.

@vanruesc
Copy link
Contributor Author

Is this something I can change? I don't see a dev branch 🤔

@Methuselah96
Copy link
Contributor

@0b5vr I actually got rid of the distinction in #662, sorry for the confusion. Feel free to advocate to bring it back, but most of the time we just ended up publishing once a month anyway.

@0b5vr
Copy link
Contributor

0b5vr commented Dec 26, 2023

@0b5vr I actually got rid of the distinction in #662, sorry for the confusion. Feel free to advocate to bring it back, but most of the time we just ended up publishing once a month anyway.

got it! I think that's a reasonable change.

@vanruesc seems we are going to go with master even when we are targeting the next update. sorry for the confusion 🙇

@Methuselah96 Methuselah96 merged commit cf2d6bf into three-types:master Jan 9, 2024
3 checks passed
@vanruesc vanruesc deleted the update-fogexp2 branch January 12, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants