-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat (Nodes): more tslFn
related typings
#744
Merged
Merged
Commits on Jan 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 29a0b14 - Browse repository at this point
Copy the full SHA 29a0b14View commit details -
feat (Nodes): Support
tslFn
with array argumentsIf the argument is an array, the array will be destructed. See: https://github.com/mrdoob/three.js/blob/r160/examples/jsm/nodes/materialx/lib/mx_noise.js
Configuration menu - View commit details
-
Copy full SHA for 121bcf9 - Browse repository at this point
Copy the full SHA 121bcf9View commit details -
feat (Nodes): Update MaterialX nodes
- Fix type of mx_hsv, mx_noise, MaterialXNodes - Add missing methods of mx_noise - Add mx_transform_color - Update test cases - the directory name was `materials` instead of `materialx`, fixed this `mx_noise.js` exports requires all arguments to exist, while `MaterialXNodes.js` exports don't
Configuration menu - View commit details
-
Copy full SHA for d9f2d7a - Browse repository at this point
Copy the full SHA d9f2d7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c6a3f19 - Browse repository at this point
Copy the full SHA c6a3f19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 49ba430 - Browse repository at this point
Copy the full SHA 49ba430View commit details
Commits on Jan 17, 2024
-
test: Fix test case for ShaderNode.ts
I forgot to put a thing in `assetSwizzable()`
Configuration menu - View commit details
-
Copy full SHA for c6cde07 - Browse repository at this point
Copy the full SHA c6cde07View commit details
Commits on Mar 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5df3d30 - Browse repository at this point
Copy the full SHA 5df3d30View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe2c1ec - Browse repository at this point
Copy the full SHA fe2c1ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 411457d - Browse repository at this point
Copy the full SHA 411457dView commit details
Commits on Apr 4, 2024
-
fix: Fix the ShaderNodeObject circular reference issue
The error is since `ContextNode` already has a member `.context` and `ShaderNodeObject` also gives it a method `.context` See: three-types#744 (comment) I believe the behavior that the node class properties takes precedance than NodeElements is same as the actual implementation See: https://github.com/mrdoob/three.js/blob/r163/examples/jsm/nodes/shadernode/ShaderNode.js
Configuration menu - View commit details
-
Copy full SHA for d05ef40 - Browse repository at this point
Copy the full SHA d05ef40View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.