Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (Nodes): more tslFn related typings #744

Merged
merged 10 commits into from
Apr 12, 2024
Merged

Commits on Jan 16, 2024

  1. Configuration menu
    Copy the full SHA
    29a0b14 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    121bcf9 View commit details
    Browse the repository at this point in the history
  3. feat (Nodes): Update MaterialX nodes

    - Fix type of mx_hsv, mx_noise, MaterialXNodes
    - Add missing methods of mx_noise
    - Add mx_transform_color
    - Update test cases
        - the directory name was `materials` instead of `materialx`, fixed this
    
    `mx_noise.js` exports requires all arguments to exist, while `MaterialXNodes.js` exports don't
    0b5vr committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    d9f2d7a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c6a3f19 View commit details
    Browse the repository at this point in the history
  5. refactor: pnpm format

    0b5vr committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    49ba430 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. test: Fix test case for ShaderNode.ts

    I forgot to put a thing in `assetSwizzable()`
    0b5vr committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    c6cde07 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Configuration menu
    Copy the full SHA
    5df3d30 View commit details
    Browse the repository at this point in the history
  2. refactor: pnpm format

    0b5vr committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    fe2c1ec View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    411457d View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. fix: Fix the ShaderNodeObject circular reference issue

    The error is since `ContextNode` already has a member `.context` and `ShaderNodeObject` also gives it a method `.context`
    
    See: three-types#744 (comment)
    
    I believe the behavior that the node class properties takes precedance than NodeElements is same as the actual implementation
    
    See: https://github.com/mrdoob/three.js/blob/r163/examples/jsm/nodes/shadernode/ShaderNode.js
    0b5vr committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    d05ef40 View commit details
    Browse the repository at this point in the history