-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebGLMultipleRenderTargets: Add new class. #85
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! ⭐
Seems the linter reports an error. Do you have an idea what is going wrong? |
@Methuselah96 Do you have an ideas how we might resolve this? 🤔 I always find it odd that you can override methods but not properties. Although @Mugen87, looking at the THREE code, wouldn't calling texture.image = {
width: this.width,
height: this.height,
depth: this.depth
}; see here. Alternatively not passing an array of Textures, would break the |
It seems |
Yeah, so this afaik wouldn't be 'allowed' in typescript... So we may need to copy the class |
Closing this PR. I'm afraid the mentioned problems exceed my TS knowledge^^. I hope somebody else can tackle this feature. BTW: It was considered in mrdoob/three.js#16390 (comment) to not extend the class from |
Why
A new type of render target was added with mrdoob/three.js#16390.
What
Adds type declaration file for
WebGLMultipleRenderTargets
.Checklist