Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Custom Shell Input #81

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Remove Custom Shell Input #81

merged 2 commits into from
Nov 21, 2023

Conversation

threeal
Copy link
Owner

@threeal threeal commented Nov 21, 2023 •
edited
Loading

This pull request removes the shell action input. It also removes the specified-shell job from the Test workflow. It closes #79.

@threeal threeal self-assigned this Nov 21, 2023
@threeal threeal changed the base branch from main to js-action November 21, 2023 13:15
@threeal threeal added this to the Version 2.0.0 milestone Nov 21, 2023
@threeal
Copy link
Owner Author

threeal commented Nov 21, 2023

The specified-generator-and-compiler-usage is failing because of missing Ninja for configuration. It will later be solved on #80.

@threeal threeal marked this pull request as ready for review November 21, 2023 13:16
@threeal threeal merged commit ded3a0b into js-action Nov 21, 2023
12 of 15 checks passed
@threeal threeal deleted the rm-shell-input branch November 21, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@threeal threeal

Labels
ci feat
Projects
None yet
Milestone
Version 2.0.0
Development

Successfully merging this pull request may close these issues.

Remove Custom Shell Input
1 participant
@threeal