Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Commands Calls #179

Merged
merged 4 commits into from
Nov 16, 2023
Merged

Simplify Commands Calls #179

merged 4 commits into from
Nov 16, 2023

Conversation

threeal
Copy link
Owner

@threeal threeal commented Nov 16, 2023

This pull request simplifies commands calls as follows:

  • Use prepack in replacement of build command (prepack will be called before calling pack).
  • Use check in replacement of format, lint, and sort commands.

This pull request also introduces the following changes:

  • Ignore package.tgz using the .gitignore file.
  • Modify Check Changes step with Check Packages step in the Build workflow.
  • Adjust commands dependencies in the Nx configuration accordingly.

It closes #178.

@threeal threeal self-assigned this Nov 16, 2023
@threeal threeal added this to the Version 1.1.0 milestone Nov 16, 2023
@threeal threeal marked this pull request as ready for review November 16, 2023 14:20
@threeal threeal merged commit 34b7cf7 into main Nov 16, 2023
5 checks passed
@threeal threeal deleted the simplify-commands branch November 16, 2023 14:21
@threeal threeal mentioned this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify Command Calls
1 participant