Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Action to Fail if Yarn Lock File Does Not Exist #129

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

threeal
Copy link
Owner

@threeal threeal commented Feb 17, 2024

This pull request resolves #128 by introducing the following changes:

  • Removes the hack preventing an error if there's no yarn.lock file.
  • Modifies the getCacheKey function to always return a cache key, even if the yarn.lock file does not exist.
  • Removes the test-action-without-lock-file job from the test workflow.

@threeal threeal added the fix label Feb 17, 2024
@threeal threeal added this to the Version 1.1.0 milestone Feb 17, 2024
@threeal threeal self-assigned this Feb 17, 2024
@threeal threeal force-pushed the action-fail-if-no-yarn-lock branch 5 times, most recently from f037e5e to 4fdd5c8 Compare February 19, 2024 10:48
@threeal threeal force-pushed the action-fail-if-no-yarn-lock branch from 3324c78 to 7a534b3 Compare February 19, 2024 12:54
@threeal threeal marked this pull request as ready for review February 19, 2024 12:58
@threeal threeal merged commit 8b75bcb into main Feb 19, 2024
7 checks passed
@threeal threeal deleted the action-fail-if-no-yarn-lock branch February 19, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify Action to Fail if Yarn Lock File Does Not Exist
1 participant