sal process needs some cleanup

[AhmedHanafy725]

• Some functions are using ps command, and it can be done with psutils.
• This method shouldn't be used for single purpose, it can be generic with args for filter, sort and limit.

js-ng/jumpscale/sals/process/__init__.py

Lines 630 to 656 in 3f8b76b

	def get_processes_info():
	"""
	Get information for top 25 running processes sorted by memory usage
	Returns:
	[list(dict)] -- list of processes info
	"""
	processes_list = []
	for proc in get_processes():
	try:
	# Fetch process details as dict
	pinfo = proc.as_dict(attrs=["pid", "name", "username"])
	pinfo["rss"] = proc.memory_info().rss / (1024 * 1024)
	pinfo["ports"] = []
	try:
	connections = proc.connections()
	except psutil.Error:
	continue
	if connections:
	for conn in connections:
	pinfo["ports"].append({"port": conn.laddr.port, "status": conn.status})
	# Append dict to list
	processes_list.append(pinfo)
	except (psutil.NoSuchProcess, psutil.AccessDenied, psutil.ZombieProcess):
	pass
	processes_list = sorted(processes_list, key=lambda procObj: procObj["rss"], reverse=True)
	return processes_list[:25]

[xmonader]

@ashraffouda you're owning this SAL, can you please review?

[xmonader]

@ashraffouda this could be a good starting issue for @sameh-farouk please guide him through once this issue is accepted

[xmonader]

Guess this won't get merged in by tmw, I'll move to next milestone.