Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pynacl to 1.4.0 #528

Closed
wants to merge 2 commits into from
Closed

Conversation

robvanmieghem
Copy link
Contributor

Solves #527

@codecov-io
Copy link

codecov-io commented Jan 1, 2021

Codecov Report

Merging #528 (35a98e8) into development (7594998) will increase coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #528      +/-   ##
===============================================
+ Coverage        70.44%   70.68%   +0.23%     
===============================================
  Files               84       84              
  Lines             3820     3820              
===============================================
+ Hits              2691     2700       +9     
+ Misses            1129     1120       -9     
Impacted Files Coverage Δ
jumpscale/tools/startupcmd/startupcmd.py 85.71% <0.00%> (-1.30%) ⬇️
jumpscale/clients/redis/redis.py 88.23% <0.00%> (+2.94%) ⬆️
jumpscale/servers/gedis/server.py 72.25% <0.00%> (+5.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7594998...35a98e8. Read the comment docs.

@abom
Copy link
Contributor

abom commented Jan 1, 2021

Please make sure to use latest poetry version, lock file shouldn't have too many changes (lock file format has been changed in recent releases).

@robvanmieghem robvanmieghem added this to the later milestone Jan 1, 2021
Copy link
Contributor

@waleedhammam waleedhammam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated poetry.lock for the newest version of poetry, @abom please check if it's ok

@abom
Copy link
Contributor

abom commented Oct 9, 2022

Will be handled in #607

@abom abom closed this Oct 9, 2022
@abom abom deleted the development_upgradepynacl branch October 10, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants