Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin jedi verision to 0.17.2 #543

Merged
merged 1 commit into from
Jan 11, 2021
Merged

pin jedi verision to 0.17.2 #543

merged 1 commit into from
Jan 11, 2021

Conversation

abom
Copy link
Contributor

@abom abom commented Jan 11, 2021

Description

Pin jedi version to "0.17.2", later versions need updated ptpython and prompt-toolkit, which break auto-completion in jsng shell.

Changes

  • Update pyproject.toml and poetry.lock

Related Issues

#542

Checklist

  • Pre-commit hook is installed to do formatting checks before committing code...etc
  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings

@abom abom merged commit f15ce78 into development Jan 11, 2021
@abom abom deleted the development_jedi branch January 11, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-motawea m-motawea m-motawea approved these changes

@waleedhammam waleedhammam waleedhammam approved these changes

@rkhamis rkhamis rkhamis approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725

@xmonader xmonader Awaiting requested review from xmonader xmonader is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abom @rkhamis @waleedhammam @m-motawea