Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove encoding option from json field... #584

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

abom
Copy link
Contributor

@abom abom commented Apr 26, 2021

Description

Prepare for python 3.9 support, as it's already not used anywhere.

Changes

  • Remove json parameter from fields.Json

Related Issues

#576

Checklist

  • Pre-commit hook is installed to do formatting checks before committing code...etc
  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings

prepare for python 3.9 support
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2021

Codecov Report

Merging #584 (179de97) into development (9c51f70) will decrease coverage by 0.45%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #584      +/-   ##
===============================================
- Coverage        70.96%   70.50%   -0.46%     
===============================================
  Files               91       91              
  Lines             4694     4693       -1     
===============================================
- Hits              3331     3309      -22     
- Misses            1363     1384      +21     
Impacted Files Coverage Δ
jumpscale/core/base/fields.py 94.89% <100.00%> (-0.02%) ⬇️
jumpscale/servers/gedis/server.py 65.26% <0.00%> (-7.37%) ⬇️
jumpscale/sals/process/__init__.py 63.63% <0.00%> (-1.38%) ⬇️
jumpscale/tools/startupcmd/startupcmd.py 85.53% <0.00%> (-1.26%) ⬇️
jumpscale/core/logging/logging.py 94.35% <0.00%> (-0.57%) ⬇️
jumpscale/clients/redis/redis.py 88.57% <0.00%> (+2.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c51f70...179de97. Read the comment docs.

@abom abom changed the base branch from development to development_gevent_update April 26, 2021 11:39
@abom abom changed the base branch from development_gevent_update to development April 26, 2021 11:40
@abom abom merged commit ab86c5a into development Apr 26, 2021
@abom abom deleted the development_json_encoding branch April 26, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants