Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove lower level debug logs from process sal #592

Merged
merged 3 commits into from
May 18, 2021

Conversation

sameh-farouk
Copy link
Member

@sameh-farouk sameh-farouk commented May 17, 2021

Description

remove lower level debug logs from process sal

Related Issues

closes #575

Checklist

  • Pre-commit hook is installed to do formatting checks before committing code...etc
  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2021

Codecov Report

Merging #592 (d8e9898) into development (2eec7af) will decrease coverage by 0.02%.
The diff coverage is 28.57%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #592      +/-   ##
===============================================
- Coverage        69.67%   69.64%   -0.03%     
===============================================
  Files               84       84              
  Lines             4283     4246      -37     
===============================================
- Hits              2984     2957      -27     
+ Misses            1299     1289      -10     
Impacted Files Coverage Δ
jumpscale/sals/process/__init__.py 63.49% <28.57%> (-0.70%) ⬇️
jumpscale/sals/nettools/__init__.py 65.46% <0.00%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2eec7af...d8e9898. Read the comment docs.

@xmonader xmonader merged commit 811a435 into development May 18, 2021
@xmonader xmonader deleted the development_clean_debug_logs_iss575 branch May 18, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove lower level debug logs after adding more test coverage to core modules
4 participants