Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial macos workflow for js-ng #594

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Conversation

sameh-farouk
Copy link
Member

@sameh-farouk sameh-farouk commented May 27, 2021

Description

initial macOS workflow for js-ng that installs the dependencies, installs the project, and runs our unit tests.
it will run only when manually triggered.

Related Issues

#593

Checklist

  • Pre-commit hook is installed to do formatting checks before committing code...etc
  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings

@sameh-farouk sameh-farouk changed the title initial macos workflow for js-sdk initial macos workflow for js-ng May 27, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2021

Codecov Report

Merging #594 (0968325) into development (811a435) will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #594      +/-   ##
===============================================
- Coverage        69.78%   69.64%   -0.15%     
===============================================
  Files               84       84              
  Lines             4246     4246              
===============================================
- Hits              2963     2957       -6     
- Misses            1283     1289       +6     
Impacted Files Coverage Δ
jumpscale/tools/startupcmd/startupcmd.py 85.53% <0.00%> (-1.26%) ⬇️
jumpscale/sals/process/__init__.py 63.19% <0.00%> (-1.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 811a435...0968325. Read the comment docs.

@xmonader xmonader merged commit fde0b26 into development Jun 21, 2021
@xmonader xmonader deleted the development-workflows-macos branch June 21, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants