change store type dyn -> static #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhamadazmy
requested changes
May 21, 2024
src/store/mod.rs
Outdated
| .expect("failed to make dir store"), | ||
| )); | ||
| } | ||
| if parsed.scheme() == "s3" { |
There was a problem hiding this comment.
this should also be done for s3s and s3s+tls as per original map
i think also you can use a match instead of multiple if statements
src/lib.rs
Outdated
| @@ -61,8 +61,8 @@ mod test { | |||
| let store1 = DirStore::new(root.join("store1")).await.unwrap(); | |||
| let mut store = Router::new(); | |||
|
|
|||
| store.add(0x00, 0x7f, Box::new(store0)); | |||
| store.add(0x80, 0xff, Box::new(store1)); | |||
| store.add(0x00, 0x7f, Stores::Dir(store0)); | |||
There was a problem hiding this comment.
In general any Store should work in place of Stores since they both implement Store trait. I did some changes to fix this and will push it
muhamadazmy
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description