Optimize dir store to have multi-layer structure #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhamadazmy
requested changes
Jul 23, 2024
iwanbk
reviewed
Aug 21, 2024
rfs/src/store/dir.rs
Outdated
|
|
||
| let path = match fs::try_exists(&dir_path).await { | ||
| Ok(true) => dir_path.join(file_name), | ||
| Ok(false) => self.root.join(file_name), |
There was a problem hiding this comment.
instead of adding this handling, why not create a once run migration script (maybe on the store new/initialization).
So we don't need to do unnecesary dir checking on each get
There was a problem hiding this comment.
Actually there is absolutely no need to check if dir exist or not on on a get. Trying to read the file directly is good enough. we will still get NotFound if the file or any of the directories on the path don't exist
muhamadazmy
requested changes
Sep 8, 2024
rfs/src/store/dir.rs
Outdated
|
|
||
| let path = match fs::try_exists(&dir_path).await { | ||
| Ok(true) => dir_path.join(file_name), | ||
| Ok(false) => self.root.join(file_name), |
There was a problem hiding this comment.
Actually there is absolutely no need to check if dir exist or not on on a get. Trying to read the file directly is good enough. we will still get NotFound if the file or any of the directories on the path don't exist
muhamadazmy
approved these changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optimize dir store to have multi-layer structure where the first layer contains directories with the first byte (like:
1f) then under each directory we have all blobs that have keys prefixed with this byte (like:1f677468c9b4e09db7630b52b4a0cc799c3f86e26e7147fc61e30fdd94f81dde,1f1b11c3509a473b77a0ffdc8d7e6a744da92293ecb3d8c38a436dd4dbdb27b5).Example tree here.
dirstore for performance #52