Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gateway fqdn integration tests #818

Merged
merged 2 commits into from
Dec 25, 2023
Merged

Fix gateway fqdn integration tests #818

merged 2 commits into from
Dec 25, 2023

Conversation

Eslam-Nawara
Copy link
Contributor

Changes

  • remove scheduler from fqdn deployment in integration test and example
  • use node 11 for gateway as the used domain hamada1.3x0.me is in node 11

Related Issues

rawdaGastan
rawdaGastan requested changes Dec 25, 2023
View reviewed changes
Copy link
Collaborator

@rawdaGastan rawdaGastan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should limit the test to devnet only (or add other hosts for all networks)

@Eslam-Nawara Eslam-Nawara force-pushed the fix-gateway_fqdn-nightly-test branch from 32509b3 to ad64911 Compare December 25, 2023 13:55
@Eslam-Nawara Eslam-Nawara merged commit b19ae95 into development Dec 25, 2023
5 checks passed
@Eslam-Nawara Eslam-Nawara deleted the fix-gateway_fqdn-nightly-test branch December 25, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rawdaGastan rawdaGastan rawdaGastan approved these changes

@mariobassem mariobassem Awaiting requested review from mariobassem mariobassem is a code owner

@ashraffouda ashraffouda Awaiting requested review from ashraffouda ashraffouda is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@AbdelrahmanElawady AbdelrahmanElawady Awaiting requested review from AbdelrahmanElawady AbdelrahmanElawady is a code owner

@xmonader xmonader Awaiting requested review from xmonader xmonader is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eslam-Nawara @rawdaGastan