Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pallet-tfgrid): improve IP validation #870

Merged
merged 6 commits into from
Oct 3, 2023

Conversation

renauter
Copy link
Collaborator

@renauter renauter commented Sep 26, 2023

Description

  1. Improve IP validation according to the following rules:
    • The gateway IP must be in the same subnet as the IP
    • The gateway IP must not be same as the public ip
  2. Apply validation while inserting public IP in create_farm() call
  3. Create a migration to remove invalid public ips from existing farms in storage

Related Issues:

Checklist:

Please delete options that are not relevant.

  • My change requires storage migration and I have included and tested it following fork off and try_runtime instructions.
  • I have added tests to cover my changes.
  • My commits follow this conventional commits guide.

@xmonader
Copy link
Contributor

@coesensbert anything else that can help improving the experience regarding this?

@renauter renauter marked this pull request as ready for review September 27, 2023 11:36
@coesensbert
Copy link
Contributor

@coesensbert anything else that can help improving the experience regarding this?

Can not think of anything to add. Last attempt was pretty thorough.

@renauter renauter merged commit 32195fa into development Oct 3, 2023
2 checks passed
@renauter renauter deleted the development_fix_ip_validation branch October 3, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A public ip on the farm public IP list cannot be the same as the gateway
4 participants