Add volume workload #1026
Merged
Add volume workload #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbdelrahmanElawady
requested review from
muhamadazmy,
mariobassem,
ashraffouda,
rawdaGastan,
Omarabdul3ziz,
xmonader,
sameh-farouk and
Eslam-Nawara
as code owners
AbdelrahmanElawady
force-pushed
the
development_volume_workload
branch
2 times, most recently
from
ec1bda1 to
19df5e8
Compare
AbdelrahmanElawady
force-pushed
the
development_volume_workload
branch
from
19df5e8 to
6566a10
Compare
rawdaGastan
reviewed
Jul 30, 2024
|
|
||
| // computed | ||
| NodeDeploymentID map[uint32]uint64 | ||
| ContractID uint64 | ||
| IPrange string | ||
| } | ||
|
|
||
| // TODO: NewDeployment should take a list of Workload interface instead of defining |
There was a problem hiding this comment.
I think we should open an issue for it
| nodes, err := deployer.FilterNodes( | ||
| context.Background(), | ||
| tfPluginClient, | ||
| generateNodeFilter(WithFreeSRU(3)), |
There was a problem hiding this comment.
Why sru is 3 and you request 2 only in the next line?
There was a problem hiding this comment.
I don't really remember but it seems 1 for Volume and 2 for minimum rootfs, the 2 next line should be 1
rawdaGastan
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add volume workload
Changes
Add volume workload
Related Issues
Checklist