Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hex secrets in login flow (and ed25519) #1113

Closed
scottyeager opened this issue Sep 15, 2023 · 9 comments
Closed

Support hex secrets in login flow (and ed25519) #1113

scottyeager opened this issue Sep 15, 2023 · 9 comments
Assignees
Milestone

Comments

@scottyeager
Copy link
Contributor

The recent update dropping Polkadot extension from Dashboard login leaves us in a bad situation:

  1. Many farms were created with the TF Connect app. They belong to a twin that's associated with a hex secret only, not a mnemonic
  2. Hex secrets can't be used to log into the dashboard, so farm management and the bridge aren't available (these features aren't in the app)

Supporting hex secrets for dashboard login is important to providing full services to all of our users, and I think it should be added urgently.

ed25519

It also looks like the dashboard only supports the sr25519 key type. It was previously possible to create accounts with ed25519 key type using the Polkadot extension (I have one such account). This is perhaps less urgent because I don't think there are as many of these accounts as there are accounts created through the TF Connect app, but it still represents a fraction of users who can no longer use the Dashboard features that require authentication.

@xmonader xmonader added this to the 2.3.0 milestone Sep 17, 2023
@coesensbert
Copy link

We are encountering this issue on devnet dashboard with Freefarm. The farm was created with an ed25519 key. When using the current dashboard (logging in using the mnemonic) we get twin ID 226 (while this should be ID 42), thus we can not manage devnet Freefarm anymore. I think this issue came up once the dashboard used the mnemonic based login (as opposed to the polkadot extension). So we need support for ed25519 keys in the dashboard.

@AhmedHanafy725
Copy link
Contributor

who will work on this, we should have:

  • drop-down select with 2 options (sr25519, ed25519) and the default should be sr25519.
  • pass whatever will be selected to the grid client in the keypairType option
  • make sure to propagate this field as well while creating a new account or activating it.
  • show a warning message for the user that using different keypair types will lead to a completely different account.

@AhmedHanafy725 AhmedHanafy725 moved this to Accepted in 3.13.x Dec 6, 2023
@zaelgohary zaelgohary removed the status in 3.13.x Dec 11, 2023
@zaelgohary zaelgohary moved this to Accepted in 3.13.x Dec 11, 2023
@zaelgohary zaelgohary self-assigned this Dec 12, 2023
@zaelgohary zaelgohary moved this from Accepted to In Progress in 3.13.x Dec 12, 2023
@zaelgohary zaelgohary moved this from In Progress to Accepted in 3.13.x Dec 12, 2023
@zaelgohary zaelgohary assigned maayarosama and unassigned zaelgohary Dec 14, 2023
@maayarosama maayarosama moved this from Accepted to In Progress in 3.13.x Dec 14, 2023
@maayarosama
Copy link
Contributor

Work Completed:

  • Added the select field for the keypair type
  • Added The warning

Work in Progress (WIP):

  • passing whatever is selected to the grid client in the keypairType option

Investigation and Solution:

@xmonader
Copy link
Contributor

I think we shouldn't allow the generation of ED keys (just allow importing them)

@maayarosama
Copy link
Contributor

Work Completed:

  • Disabled creating nee account when using hex seed
  • passed the KeypairType to the grid

Work in Progress (WIP):

  • the positioning of the select field

  • saving the keypair type as a static value somewhere same as mnemonic

Investigation and Solution:

@maayarosama maayarosama moved this from In Progress to Pending review in 3.13.x Dec 18, 2023
@maayarosama
Copy link
Contributor

Work Completed:

  • Re-validationg when keyPair change
  • Enhancements to warning alert
  • Adding an alert in case of choosing ED key telling the user that generation of ed keys isn't supported

Work in Progress (WIP):

Investigation and Solution:

@maayarosama maayarosama moved this from Pending review to In Verification in 3.13.x Dec 21, 2023
@khaledyoussef24
Copy link
Contributor

blocked on #1690 to verify that we can create a twin with a hex seed also

@khaledyoussef24 khaledyoussef24 moved this from In Verification to Blocked in 3.13.x Jan 2, 2024
@khaledyoussef24
Copy link
Contributor

env used : devnet
version used : 228c723
verified now user can log in and activate account from mnemonic and hex seed
image
image

test lodge : https://app.testlodge.com/a/26076/projects/40893/suites/234374?expand_section=422331#case_4161528

@AhmedHanafy725 AhmedHanafy725 moved this from Blocked to In Verification in 3.13.x Jan 2, 2024
@khaledyoussef24 khaledyoussef24 moved this from In Verification to Done in 3.13.x Jan 2, 2024
@ramezsaeed
Copy link
Contributor

Verified:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

No branches or pull requests

8 participants