Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hint when no farms #1722

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Conversation

amiraabouhadid
Copy link
Contributor

@amiraabouhadid amiraabouhadid commented Dec 18, 2023

Description

added a hint to the user to change key types from TFChain wallet when he/she cannot see their farms.

Related Issues

#1707

image

@AlaaElattar
Copy link
Contributor

  • I don't understand the point of the hint. maybe the user has no farms, why to mention keytype ?

Copy link
Contributor

@ehab-hassan ehab-hassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at design

@amiraabouhadid
Copy link
Contributor Author

amiraabouhadid commented Dec 19, 2023

  • I don't understand the point of the hint. maybe the user has no farms, why to mention keytype ?

please refer to #1113. The same mnemonic but with different keytypes leads to essentially different accounts so user might think he has farms in this account but really they are in the account with the other keytype. Hence why a hint is needed. Hope this clears it up.

@amiraabouhadid amiraabouhadid merged commit 75c70b4 into development Dec 19, 2023
3 checks passed
@AhmedHanafy725 AhmedHanafy725 deleted the dev_add_hint_no_user_farms branch December 19, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants