Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't add public configuration to my node #1618

Closed
A-Harby opened this issue Dec 7, 2023 · 6 comments
Closed

Can't add public configuration to my node #1618

A-Harby opened this issue Dec 7, 2023 · 6 comments
Assignees
Labels
dashboard type_bug Something isn't working
Milestone

Comments

@A-Harby
Copy link
Contributor

A-Harby commented Dec 7, 2023

Description

Devnet, 2d54818.

I can't add any public configuration to my node and keep getting this error.

image

And also the error message must be more clearer to the user!

Steps to reproduce

  1. Connect your wallet (your account must have a node).
  2. Navigate to the farms by expanding the dashboard from the sidebar.
  3. From your node table, click on Add public IP from within your node.
  4. Fill in the input and press save.
@ramezsaeed
Copy link
Contributor

Ipv4 should not be the same as the gateway

@ramezsaeed ramezsaeed added this to the 2.3.0 milestone Dec 11, 2023
@coesensbert
Copy link

and should be in the subnet mask range because of on-chain validation

@zaelgohary zaelgohary moved this to Accepted in 3.13.x Dec 11, 2023
@AlaaElattar AlaaElattar self-assigned this Dec 12, 2023
@AlaaElattar AlaaElattar moved this from Accepted to In Progress in 3.13.x Dec 12, 2023
@AlaaElattar
Copy link
Contributor

Work Completed

  • Added condition to check they're different before sending the request.

@AlaaElattar AlaaElattar moved this from In Progress to Pending review in 3.13.x Dec 12, 2023
@AlaaElattar AlaaElattar moved this from Pending review to In Progress in 3.13.x Dec 19, 2023
@AlaaElattar
Copy link
Contributor

Work Complete:

  • The error msg was triggered at wrong cases and that is fixed now.

@AlaaElattar AlaaElattar moved this from In Progress to Pending review in 3.13.x Dec 19, 2023
@zaelgohary zaelgohary moved this from Pending review to In Verification in 3.13.x Dec 26, 2023
@A-Harby
Copy link
Contributor Author

A-Harby commented Jan 2, 2024

Verified,
Devnet 33c308d.

TC2218 - Public Config Input Validation.

The same IP and gateway validation were added.
image
image

After fixing the wrong input, IP was added.
image

@A-Harby A-Harby moved this from In Verification to Done in 3.13.x Jan 2, 2024
@ramezsaeed
Copy link
Contributor

Verified:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard type_bug Something isn't working
Projects
No open projects
Status: Done
Development

No branches or pull requests

4 participants