-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check that ip should be different from gateway #1669
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think validation should happen before clicking the button and making the request. If 2 IPs are the same, the button should be disabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
The validation isn't very accurate in some cases like the one seen below the validation is triggered with incorrect cases and in the case that should trigger it, it doesn't get triggered.
Screencast.from.13-12-23.13.50.21.webm
please check this comment |
should be fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good! Just a small enhancement.
Description
Changes
Related Issues
#1618
#1668
#1732
Screencast.from.12-19-2023.01.16.27.PM.webm
Checklist