Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird Behavior in Add a public config in my farms page #1668

Closed
AlaaElattar opened this issue Dec 12, 2023 · 8 comments
Closed

Weird Behavior in Add a public config in my farms page #1668

AlaaElattar opened this issue Dec 12, 2023 · 8 comments
Assignees
Labels
type_bug Something isn't working
Milestone

Comments

@AlaaElattar
Copy link
Contributor

Description

There's weird behavior as its seen below in the validations.
Why when i type in IPv4 gateway validation is working ?

Screencast.from.12-12-2023.12.05.13.PM.webm
@zaelgohary zaelgohary added the type_bug Something isn't working label Dec 14, 2023
@zaelgohary zaelgohary added this to the 2.3.0 milestone Dec 14, 2023
@zaelgohary
Copy link
Contributor

All validation is triggered if one input is being validated.

@zaelgohary zaelgohary moved this to Pending review in 3.13.x Dec 17, 2023
@AlaaElattar AlaaElattar moved this from Pending review to In Progress in 3.13.x Dec 18, 2023
@AlaaElattar AlaaElattar moved this from In Progress to In Verification in 3.13.x Dec 18, 2023
@AlaaElattar
Copy link
Contributor Author

  • It's not actually an issue, it's implemented like this for a reason.
  • ipv4 & gw4 are a must in form. I can't submit any input unless they're full
  • if ipv4 triggered -> gw4 should be too and vice versa
  • if ipv6 triggered -> gw6 should be too and vice versa
  • domain optiona
  • This explains the behavior of the form.

@0oM4R
Copy link
Contributor

0oM4R commented Dec 18, 2023

should we trigger the validation if the other value is valid only ?

  • It's not actually an issue, it's implemented like this for a reason.
  • ipv4 & gw4 are a must in form. I can't submit any input unless they're full
  • if ipv4 triggered -> gw4 should be too and vice versa
  • if ipv6 triggered -> gw6 should be too and vice versa
  • domain optiona
  • This explains the behavior of the form.

@AlaaElattar AlaaElattar moved this from In Verification to In Progress in 3.13.x Dec 18, 2023
@AlaaElattar
Copy link
Contributor Author

Work In Progess (WIP):

@AlaaElattar
Copy link
Contributor Author

Work Completed :

@AlaaElattar AlaaElattar moved this from In Progress to Pending review in 3.13.x Dec 19, 2023
@zaelgohary zaelgohary moved this from Pending review to In Verification in 3.13.x Dec 26, 2023
@A-Harby
Copy link
Contributor

A-Harby commented Dec 27, 2023

One case is not fixed yet: when any other input is being typed and validated and there is already a wrong validation on the other inputs, all of them will be affected and revalidated.

Threefold.Dashboard._.Your.Farms.webm
Threefold.Dashboard._.Your.Farms.1.webm

@A-Harby A-Harby moved this from In Verification to Accepted in 3.13.x Dec 27, 2023
@AlaaElattar AlaaElattar moved this from Accepted to In Progress in 3.13.x Dec 28, 2023
@AlaaElattar AlaaElattar moved this from In Progress to Accepted in 3.13.x Dec 28, 2023
@AlaaElattar AlaaElattar moved this from Accepted to In Progress in 3.13.x Dec 31, 2023
@AlaaElattar
Copy link
Contributor Author

Investigation and Solution:

@AlaaElattar AlaaElattar moved this from In Progress to Blocked in 3.13.x Dec 31, 2023
@AlaaElattar AlaaElattar moved this from Blocked to In Verification in 3.13.x Dec 31, 2023
@A-Harby
Copy link
Contributor

A-Harby commented Jan 2, 2024

Beside on the comment this issue is fixed and weird reverifying should be fixed on an other issue #1668 (comment).

TC2216 - Add Public Config

@A-Harby A-Harby moved this from In Verification to Done in 3.13.x Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type_bug Something isn't working
Projects
No open projects
Status: Done
Development

No branches or pull requests

5 participants