Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find a better way to show the dedicated node discount info notification #1892

Closed
ramezsaeed opened this issue Jan 8, 2024 · 8 comments
Closed
Assignees
Labels
playground type_feature New feature or request
Milestone

Comments

@ramezsaeed
Copy link
Contributor

in the dedicated node page;
I need to put the mouse on the price to see the discount info notification.
for someone doesn't know there is discount already he may not put the mouse on the price, and will end up he doesn't know there is even a discount available.

Screenshot from 2024-01-08 12-37-03

@ramezsaeed ramezsaeed added this to the 2.4.0 milestone Jan 11, 2024
@AlaaElattar AlaaElattar added type_feature New feature or request playground labels Jan 15, 2024
@MohamedElmdary MohamedElmdary moved this to Accepted in 3.14.x Feb 14, 2024
@AhmedHanafy725 AhmedHanafy725 modified the milestones: 2.4.0, 2.5.0 Mar 25, 2024
@zaelgohary
Copy link
Contributor

Should be done in the node finder.

@ehab-hassan ehab-hassan moved this from Accepted to In Progress in 3.14.x May 20, 2024
@ehab-hassan
Copy link
Contributor

maybe we can show a chip of the discount or just icon if there is a discount in this node and show a tooltip when hovering on it.

Group 2

@ehab-hassan
Copy link
Contributor

Work in Progress (WIP)
I think ll just icon beside the price.
Icon added but may will add a small animation(scale in/out) to get the user's attention.

@ehab-hassan
Copy link
Contributor

Work Completed

discount.mp4

@ehab-hassan ehab-hassan moved this from In Progress to Pending Review in 3.14.x May 21, 2024
@ehab-hassan ehab-hassan moved this from Pending Review to In Progress in 3.14.x May 21, 2024
@ehab-hassan
Copy link
Contributor

Work in Progress
Figuring out how to make discounts at the dedicated node

@ehab-hassan ehab-hassan moved this from In Progress to In Verification in 3.14.x May 22, 2024
@A-Harby
Copy link
Contributor

A-Harby commented May 28, 2024

discount is a lot more noticeable now than before, and different packages are applied with changing balances.
But the discount doesn't change if I log in or connect my wallet until I refresh the page and reset the filters.
And the same happens with logout.

screen-capture.4.webm

@A-Harby A-Harby moved this from In Verification to Accepted in 3.14.x May 28, 2024
@ehab-hassan
Copy link
Contributor

@A-Harby this is related to another issue here #1978

@A-Harby A-Harby moved this from Accepted to In Verification in 3.14.x May 29, 2024
@khaledyoussef24
Copy link
Contributor

@khaledyoussef24 khaledyoussef24 moved this from In Verification to Done in 3.14.x Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
playground type_feature New feature or request
Projects
Status: Done
Development

No branches or pull requests

7 participants