Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the dedicated node discount #2744

Merged
merged 3 commits into from
May 22, 2024

Conversation

ehab-hassan
Copy link
Contributor

@ehab-hassan ehab-hassan commented May 20, 2024

Description

Make the dedicated node discount clearer for the user

Changes

add icon with warning color

Related Issues

#1892

Documentation PR

discount.mp4

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@ehab-hassan ehab-hassan marked this pull request as ready for review May 21, 2024 09:08
@ehab-hassan ehab-hassan changed the title show the dedicated node discount Show the dedicated node discount May 21, 2024
Copy link
Contributor

@AlaaElattar AlaaElattar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The discount icon appears on shared node.
Screencast.from.05-21-2024.01.58.04.PM.webm

image

@ehab-hassan
Copy link
Contributor Author

  • The discount icon appears on shared node.

Screencast.from.05-21-2024.01.58.04.PM.webm
image

fixed @AlaaElattar please check

@ehab-hassan ehab-hassan merged commit 3c73c2b into development May 22, 2024
3 checks passed
@ehab-hassan ehab-hassan deleted the development_dedicatednode_discount branch May 22, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants