Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Calculator] errors in console while typing. #1899

Closed
0oM4R opened this issue Jan 8, 2024 · 2 comments
Closed

[Calculator] errors in console while typing. #1899

0oM4R opened this issue Jan 8, 2024 · 2 comments
Assignees
Labels
type_bug Something isn't working
Milestone

Comments

@0oM4R
Copy link
Contributor

0oM4R commented Jan 8, 2024

if the user removed the current value to type a new one in balance field
it logs an error to console, and if the user moved to other fields this cause unwanted behavior.
image

Suggestion:
prevent calculating the price if the balance is not a valid value

@ramezsaeed ramezsaeed added this to the 2.4.0 milestone Jan 11, 2024
@ramezsaeed ramezsaeed added the type_bug Something isn't working label Jan 11, 2024
@MohamedElmdary MohamedElmdary moved this to Accepted in 3.14.x Feb 14, 2024
@AlaaElattar AlaaElattar self-assigned this Feb 22, 2024
@AlaaElattar AlaaElattar moved this from Accepted to In Progress in 3.14.x Feb 22, 2024
@AlaaElattar
Copy link
Contributor

Work In Progress :

  • Found why this happens but still trying multiple solutions.

@AlaaElattar AlaaElattar removed their assignment Feb 27, 2024
@AlaaElattar AlaaElattar moved this from In Progress to Accepted in 3.14.x Feb 27, 2024
@MohamedElmdary MohamedElmdary self-assigned this Mar 3, 2024
@MohamedElmdary MohamedElmdary moved this from Accepted to In Progress in 3.14.x Mar 3, 2024
@MohamedElmdary MohamedElmdary moved this from In Progress to Pending Review in 3.14.x Mar 3, 2024
@0oM4R 0oM4R moved this from Pending Review to Accepted in 3.14.x Mar 12, 2024
@MohamedElmdary MohamedElmdary moved this from Accepted to Pending Review in 3.14.x Mar 24, 2024
@MohamedElmdary MohamedElmdary moved this from Pending Review to In Verification in 3.14.x Mar 27, 2024
@khaledyoussef24
Copy link
Contributor

verified on devnet
version : f530d72
console error no longer appears while typing.
Screenshot 2024-03-30 at 12 50 31 PM
Screenshot 2024-03-30 at 12 50 49 PM

@khaledyoussef24 khaledyoussef24 moved this from In Verification to Done in 3.14.x Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type_bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

5 participants