Rewrite pricing calculator #2308
Conversation
MohamedElmdary
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
Mahmoud-Emad,
amiraabouhadid,
AlaaElattar,
0oM4R and
mohamedamer453
as code owners
Screencast.from.03-05-2024.04.40.16.PM.webm |
- style: no longer show loader instead write loading...
update loading behaviour but what about toggles spacing? |
|
|
|
| <VRow v-else> | ||
| <VCol cols="12"> | ||
| <VAlert type="error"> | ||
| Please provide a valid data inorder to calculate your deployment price correctly. |
There was a problem hiding this comment.
I think the alert should be more clear, it should mention which field is invalid. what do you think?
There was a problem hiding this comment.
there is already an error shown on that specific field ... we can know instantly which field has error without checking every field over and over
| :style="{ background: computePackageColor(priceTask.data?.sharedPackage.package) }" | ||
| > | ||
| <p> | ||
| Cost of reservation on a <strong v-text="'Shared Node'" /><br /> |
There was a problem hiding this comment.
I'm not sure if we should mention the package's name here or if the background color is enough?
There was a problem hiding this comment.
@maayarosama what do u mean?
please add some ss if something is not working correctly
There was a problem hiding this comment.
Let's ignore my suggestion here as it's not needed
Description
Pricing calculator had tons of issue so we decided to rewrite it in a better way
Changes
Rewrite pricing calculator
Related Issues
Checklist