Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outsource default urls from grid_client code #2311

Closed
MohamedElmdary opened this issue Mar 3, 2024 · 2 comments
Closed

Outsource default urls from grid_client code #2311

MohamedElmdary opened this issue Mar 3, 2024 · 2 comments
Assignees
@zaelgohary
Labels
enhancements Small changes that can enhance the code/UI grid_client
Milestone
2.4.0

Comments

@MohamedElmdary
Copy link
Member

Search first

Outsource default urls from grid_client code
@MohamedElmdary MohamedElmdary added grid_client enhancements Small changes that can enhance the code/UI labels Mar 3, 2024
@ramezsaeed ramezsaeed added this to 3.14.x Mar 7, 2024
@ramezsaeed ramezsaeed added this to the 2.4.0 milestone Mar 7, 2024
@0oM4R 0oM4R moved this to Accepted in 3.14.x Mar 18, 2024
@AhmedHanafy725 AhmedHanafy725 modified the milestones: 2.4.0, 2.5.0 Mar 25, 2024
@zaelgohary zaelgohary self-assigned this Apr 16, 2024
@zaelgohary zaelgohary moved this from Accepted to In Progress in 3.14.x Apr 16, 2024
@zaelgohary zaelgohary mentioned this issue Apr 16, 2024
Merged
5 tasks
@zaelgohary zaelgohary moved this from In Progress to Pending Review in 3.14.x Apr 16, 2024
@zaelgohary zaelgohary moved this from Pending Review to Accepted in 3.14.x Apr 17, 2024
@zaelgohary zaelgohary moved this from Accepted to Pending Review in 3.14.x Apr 17, 2024
@zaelgohary
Copy link
Contributor

zaelgohary commented Apr 17, 2024 •
edited
Loading

Work completed:

Refactored the getDefaultUrls function instead of outsourcing the URLs as they're not used anywhere else in the Grid Client.

@amiraabouhadid amiraabouhadid moved this from Pending Review to In Verification in 3.14.x Apr 17, 2024
@Mahmoud-Emad Mahmoud-Emad modified the milestones: 2.5.0, 2.4.0 Apr 21, 2024
@Mahmoud-Emad
Copy link
Contributor

Refactored, Good job Zainab!

@github-project-automation github-project-automation bot moved this from In Verification to Done in 3.14.x Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zaelgohary zaelgohary

Labels
enhancements Small changes that can enhance the code/UI grid_client
Projects
3.14.x
Status: Done
Milestone
2.4.0
Development

No branches or pull requests
5 participants
@ramezsaeed @MohamedElmdary @zaelgohary @AhmedHanafy725 @Mahmoud-Emad