Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor getDefaultUrls function #2568

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Refactor getDefaultUrls function #2568

merged 2 commits into from
Apr 17, 2024

Conversation

zaelgohary
Copy link
Contributor

@zaelgohary zaelgohary commented Apr 16, 2024 •
edited
Loading

Changes

Refactor getDefaultUrls function

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@zaelgohary zaelgohary marked this pull request as draft April 16, 2024 11:57
@zaelgohary zaelgohary marked this pull request as ready for review April 17, 2024 08:32
@amiraabouhadid amiraabouhadid merged commit 4b54233 into development Apr 17, 2024
2 checks passed
@amiraabouhadid amiraabouhadid deleted the development_refactor_default_urls branch April 17, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amiraabouhadid amiraabouhadid amiraabouhadid approved these changes

@MohamedElmdary MohamedElmdary MohamedElmdary approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zaelgohary @MohamedElmdary @amiraabouhadid