Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zmount unit tests #2459

Closed
Tracked by #2352
zaelgohary opened this issue Mar 18, 2024 · 4 comments
Closed
Tracked by #2352

Add zmount unit tests #2459

zaelgohary opened this issue Mar 18, 2024 · 4 comments
Assignees
Labels
type_feature New feature or request
Milestone

Comments

@zaelgohary
Copy link
Contributor

zaelgohary commented Mar 18, 2024

Which package/s are you suggesting this feature for?

grid_client

Describe the solution you'd like

Add tests for zmount.ts

@zaelgohary zaelgohary added the type_feature New feature or request label Mar 18, 2024
@AhmedHanafy725 AhmedHanafy725 modified the milestones: 2.4.0, 2.6.0 Mar 24, 2024
@AhmedHanafy725 AhmedHanafy725 removed this from 3.14.x May 29, 2024
@zaelgohary zaelgohary self-assigned this Jun 6, 2024
@zaelgohary zaelgohary moved this to In Progress in 3.15.x Jun 6, 2024
@zaelgohary zaelgohary mentioned this issue Jun 6, 2024
5 tasks
@zaelgohary zaelgohary moved this from In Progress to Pending Review in 3.15.x Jun 6, 2024
@zaelgohary
Copy link
Contributor Author

Work completed:

Added zmount tests.

@zaelgohary zaelgohary moved this from Pending Review to In Verification in 3.15.x Jun 9, 2024
@A-Harby A-Harby moved this from In Verification to Accepted in 3.15.x Jul 15, 2024
@zaelgohary
Copy link
Contributor Author

The tests workflow is failing daily because of this test. https://github.com/threefoldtech/tfgrid-sdk-ts/actions/runs/9932122876/job/27432996148 https://github.com/threefoldtech/tfgrid-sdk-ts/runs/27433452415#r0s19, https://github.com/threefoldtech/tfgrid-sdk-ts/runs/27415463877#r0s19.

Could you check it again?

This has nothing to do with the tests but with the workload validation itself. All tests should be working fine once #3038 is done.

@zaelgohary zaelgohary moved this from Accepted to In Verification in 3.15.x Jul 15, 2024
@A-Harby
Copy link
Contributor

A-Harby commented Jul 15, 2024

The tests workflow is failing daily because of this test. https://github.com/threefoldtech/tfgrid-sdk-ts/actions/runs/9932122876/job/27432996148 https://github.com/threefoldtech/tfgrid-sdk-ts/runs/27433452415#r0s19, https://github.com/threefoldtech/tfgrid-sdk-ts/runs/27415463877#r0s19.
Could you check it again?

This has nothing to do with the tests but with the workload validation itself. All tests should be working fine once #3038 is done.

#2459 (comment)
Then this issue can be closed as the tests are doing there job, failing if something is working, and the other issue should be verified once its done and made sure the tests are passed too.

@A-Harby A-Harby moved this from In Verification to Done in 3.15.x Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type_feature New feature or request
Projects
Status: Done
Development

No branches or pull requests

4 participants