Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rmb peer client docs #2658

Closed
zaelgohary opened this issue May 8, 2024 · 3 comments
Closed

Add rmb peer client docs #2658

zaelgohary opened this issue May 8, 2024 · 3 comments
Assignees
@Mahmoud-Emad
Labels
type_feature New feature or request
Milestone
2.5.0

Comments

@zaelgohary
Copy link
Contributor

Which package/s are you suggesting this feature for?

rmb_peer_client

Is your feature request related to a problem? Please describe

image

Describe the solution you'd like

Add proper documentation and describe how to generate the ts types from the prototype and the main flow of the package.
@zaelgohary zaelgohary added the type_feature New feature or request label May 8, 2024
@ramezsaeed ramezsaeed changed the title Add rmb peer cient docs Add rmb peer client docs May 8, 2024
@ramezsaeed ramezsaeed added this to 3.14.x May 8, 2024
@ramezsaeed ramezsaeed added this to the 2.5.0 milestone May 8, 2024
@ramezsaeed ramezsaeed moved this to Accepted in 3.14.x May 8, 2024
@Mahmoud-Emad Mahmoud-Emad self-assigned this May 12, 2024
@Mahmoud-Emad Mahmoud-Emad moved this from Accepted to In Progress in 3.14.x May 12, 2024
@Mahmoud-Emad
Copy link
Contributor

Work paused here due to currently working on #2683

@Mahmoud-Emad Mahmoud-Emad mentioned this issue May 13, 2024
Merged
5 tasks
@Mahmoud-Emad Mahmoud-Emad moved this from In Progress to In Verification in 3.14.x May 13, 2024
@Mahmoud-Emad
Copy link
Contributor

Issue update

Work done, updated the docs

@Mahmoud-Emad Mahmoud-Emad moved this from In Verification to Pending Review in 3.14.x May 13, 2024
@Mahmoud-Emad Mahmoud-Emad moved this from Pending Review to In Verification in 3.14.x May 30, 2024
@khaledyoussef24
Copy link
Contributor

verified statically
RMB read me docs is now available here.
it is clear how to make a request or read a request
and also the manual was updated for this part src/documentation/developers/internals/rmb/rmb_intro.md

@khaledyoussef24 khaledyoussef24 moved this from In Verification to Done in 3.14.x Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mahmoud-Emad Mahmoud-Emad

Labels
type_feature New feature or request
Projects
3.14.x
Status: Done
Milestone
2.5.0
Development

No branches or pull requests
4 participants
@ramezsaeed @zaelgohary @Mahmoud-Emad @khaledyoussef24