Update installation instructions in RMB Peer, Direct README.md
#2679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mahmoud-Emad
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
amiraabouhadid,
AlaaElattar,
0oM4R,
mohamedamer453 and
samaradel
as code owners
- Added step-by-step instructions for installing dependencies - Clarified system requirements
Mahmoud-Emad
changed the title
Peer, Direct README.md
zaelgohary
reviewed
May 13, 2024
- Update DEVELOPERS.README.md in rmb_direct_client to refine the guide and correct typos. - Update README.md in rmb_peer_client to specify that it's a TypeScript library.
xmonader
reviewed
May 13, 2024
xmonader
reviewed
May 13, 2024
amiraabouhadid
approved these changes
May 13, 2024
xmonader
reviewed
May 13, 2024
xmonader
reviewed
May 13, 2024
Mahmoud-Emad
force-pushed
the
development_rmb_docs
branch
from
7949c2a to
d3dc786
Compare
|
why did we change typescript version? also using 4.7 not 5.x? @Mahmoud-Emad |
There was an error when tried to build the types, and @AhmedHanafy725 suggested that we put this version |
maayarosama
requested changes
May 14, 2024
maayarosama
approved these changes
May 14, 2024
|
@xmonader any changes?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update installation instructions in RMB Peer, Direct README.md
Changes
Related Issues
Checklist