-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node Filters #1580
Merged
Mahmoud-Emad
merged 7 commits into
development_313
from
development_313_dedicated_nodes_filter
Dec 6, 2023
Merged
Node Filters #1580
Mahmoud-Emad
merged 7 commits into
development_313
from
development_313_dedicated_nodes_filter
Dec 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mahmoud-Emad
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
amiraabouhadid,
Omarabdul3ziz,
AlaaElattar and
0oM4R
as code owners
December 5, 2023 09:33
…f the default value instead of using direct object () => obj.
…sue in the max int value in the filters.
This was referenced Dec 5, 2023
mohamedamer453
approved these changes
Dec 6, 2023
|
zaelgohary
reviewed
Dec 6, 2023
Hey @AlaaElattar the explorer farm (IDs) I saw it in the old dashboard it was like I did, and the implementation of it was searched by farm ID since we are in the farm view itself if you propose that we make all of them similar, we'll need to open an issue for that feature, what do you think? |
amiraabouhadid
requested changes
Dec 6, 2023
packages/playground/src/dashboard/components/dedicated_nodes_table.vue
Outdated
Show resolved
Hide resolved
opened an issue #1592 |
zaelgohary
approved these changes
Dec 6, 2023
amiraabouhadid
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
() => obj
.Changes
Related Issues
Screenshots/Video
Screencast.from.12-05-2023.03.01.35.PM.webm
Checklist