Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Filters #1580

Merged
Merged

Conversation

Mahmoud-Emad
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad commented Dec 5, 2023

Description

  • Resolved the reset filter issues by implementing a function that returns an object with the default values. This approach replaces the previous direct object usage () => obj.
  • Reset filters in the farms page, updated the nodes page, and addressed an issue related to the max integer value in the filters.

Changes

  • Update Node Filters and Conversion to Vue 3 Composition API
  • Fix Reset Filter Issues using a Function that returns an object instead of using a direct object
  • Reset Filters in the Farms Page, Nodes Page Update, and Max Int Value Fix

Related Issues

Screenshots/Video

Screencast.from.12-05-2023.03.01.35.PM.webm

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@Mahmoud-Emad Mahmoud-Emad changed the title Make the panels expended by default. Node Filters Dec 5, 2023
@Mahmoud-Emad Mahmoud-Emad marked this pull request as draft December 5, 2023 09:33
@Mahmoud-Emad Mahmoud-Emad self-assigned this Dec 5, 2023
@Mahmoud-Emad Mahmoud-Emad marked this pull request as ready for review December 5, 2023 13:00
This was referenced Dec 5, 2023
@AlaaElattar
Copy link
Contributor

  • The hint in explorer farms for Farm ID is different from hint in explorer nodes.
  • also it should be Farm ID in both of them.

image

image

@AlaaElattar
Copy link
Contributor

  • What do u think about hiding the arrow icon from css style, if we keep it open always and ?
  • It gives me a feeling that i can close it but it won't close.

yarn.lock Show resolved Hide resolved
@Mahmoud-Emad
Copy link
Contributor Author

  • The hint in explorer farms for Farm ID is different from hint in explorer nodes.
  • also it should be Farm ID in both of them.

image

image

Hey @AlaaElattar

the explorer farm (IDs)
the farms farm(ID)

I saw it in the old dashboard it was like I did, and the implementation of it was searched by farm ID since we are in the farm view itself

if you propose that we make all of them similar, we'll need to open an issue for that feature, what do you think?

packages/playground/src/utils/filter_farms.ts Show resolved Hide resolved
packages/playground/src/views/farms.vue Outdated Show resolved Hide resolved
packages/playground/src/views/nodes.vue Outdated Show resolved Hide resolved
packages/playground/src/utils/filter_farms.ts Outdated Show resolved Hide resolved
packages/playground/src/utils/filter_farms.ts Outdated Show resolved Hide resolved
@AlaaElattar
Copy link
Contributor

  • The hint in explorer farms for Farm ID is different from hint in explorer nodes.

opened an issue #1592

@amiraabouhadid
Copy link
Contributor

Please make the HDD filter in dedicated nodes use TB instead of GB to be consistent with the unit used in the dedicated nodes table
Screenshot from 2023-12-06 12-09-28

@zaelgohary
Copy link
Contributor

Please make the HDD filter in dedicated nodes use TB instead of GB to be consistent with the unit used in the dedicated nodes table Screenshot from 2023-12-06 12-09-28

Units may change according to the node resources, so, HDD might have a GB unit too.

@Mahmoud-Emad Mahmoud-Emad merged commit 2d54818 into development_313 Dec 6, 2023
@Mahmoud-Emad Mahmoud-Emad deleted the development_313_dedicated_nodes_filter branch December 6, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants