Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating TFT Farmed field #1655

Merged
merged 2 commits into from
Dec 17, 2023
Merged

Conversation

maayarosama
Copy link
Contributor

@maayarosama maayarosama commented Dec 11, 2023

Description

Updating TFT Farmed field because it was confusing
Screenshot from 2023-12-11 13-34-23

Related Issues

#1575

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

Copy link
Contributor

@mohamedamer453 mohamedamer453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding this value

image

i'm not sure if it's supposed to be the current tft value or not, but if it's the current tft value then it should be updated since according to stellar the current value is 1 tft -> 0.016 usd

@maayarosama
Copy link
Contributor Author

Regarding this value

image

i'm not sure if it's supposed to be the current tft value or not, but if it's the current tft value then it should be updated since according to stellar the current value is 1 tft -> 0.016 usd

It's not the current TFT value, it's the value of TFT when it was minted

<input-tooltip
inline
:alignCenter="true"
:tooltip="`${(item.Minting.tft_connection_price / 1e3).toFixed(3)}$/TFT`"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make it TFT/X$ ?

other than that it's good to merge

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the the price of 1 TFT is 0.08 dollar in this case, it would make no sense to show it as 0.08 tft/$ because this implies that 0.08 tft is 1 dollar, however I can phrase it as follows:
1 TFT = 0.08$
What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do 🙏

@AhmedHanafy725 AhmedHanafy725 merged commit 8c32384 into development Dec 17, 2023
3 checks passed
@AhmedHanafy725 AhmedHanafy725 deleted the development_tft_farmed branch December 17, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants